alex added inline comments.

INLINE COMMENTS

> meven wrote in kpluginselector.cpp:855
> Adding a fileName field to KCModuleProxy would make more sense to me, and do 
> it by default.
> Plus KCModuleProxy has already access to the fileName since it receives 
> moduleInfo. 
> But I am not a specialist.

You could add a field to the KCModule class (thats where you ultimately want to 
access the fileName).
But then the downside is that you don't have them as a constructor argument.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Reply via email to