marcingu marked 2 inline comments as done. marcingu added inline comments. INLINE COMMENTS
> dfaure wrote in thumbnail.h:93 > This will break compilation on Windows, I assume? > > On Unix, is the corresponding include present in this file? The lack of > context makes reviewing difficult indeed. Any chance to move this to gitlab? > (see invent.kde.org) On Windows this check is assumed false. So in case encrypted file shares filesystem with thumbnails directory, it can take longer as those won't be cached, but it will work. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
