marcingu added inline comments.

INLINE COMMENTS

> dfaure wrote in thumbnail.cpp:776
> I don't see how stat would succeed and st_dev would be 0, but I could be 
> wrong. Maybe assert that it's not 0, at least?

If st_dev cannot be 0 on successful call of lstat, I don't think there's need 
to change anything. m_thumbnailDirDeviceId will remain zero only if lstat 
returns error and as long it's zero sharesFilesystemWithThumbRoot will return 
false.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

Reply via email to