marcingu marked 3 inline comments as done. marcingu added inline comments. INLINE COMMENTS
> dfaure wrote in thumbnail.h:93 > Which check? This is a member variable, and I'm not sure the dev_t type will > be known at all on Windows. > But if you're not sure either, let's wait until CI tells us. Oh, I missed it, because types.h it's not explicitly included. I also removed lstat usagen on Windows. Thanks for pointing that out. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov