bruns added inline comments.
INLINE COMMENTS
> jobtest.cpp:467
> + path.removeLast();
> + QString writeTest = path.join("/") + "/fsXattrTestFile";
> + createTestFile(writeTest);
const QString
And if you just call this with the target directory (e.g. ` homeTmpDir()`), you
can skip the split/join dance.
> jobtest.cpp:780
> + checkXattrFsSupport(filePath);
> + checkXattrFsSupport(dest);
> + if (!m_SkipXattr) {
This will set `m_SkipXattr` unconditionally even if the source FS does not
support Xattrs.
REVISION DETAIL
https://phabricator.kde.org/D17816
To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann,
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun,
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh
