> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It!
KFileMetaData being in use by itself, IMHO Baloo problematics should not block this correction. - Matthieu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 ----------------------------------------------------------- On mars 14, 2017, 10:16 après-midi, Igor Poboiko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > ----------------------------------------------------------- > > (Updated mars 14, 2017, 10:16 après-midi) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > ------- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > ----- > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > ------- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >