> On Март 15, 2017, 4:13 д.п., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it?
I didn't see much performance issues; and from what can I see, DB size didn't change much after reindexing, so there is no redundant extractors as far as I can see. Concerning performance - I don't believe there is much overhead too much I think we should instead use profilers to find bottlenecks. I don't think it is one of them. - Igor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 ----------------------------------------------------------- On Март 14, 2017, 9:16 п.п., Igor Poboiko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > ----------------------------------------------------------- > > (Updated Март 14, 2017, 9:16 п.п.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > ------- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > ----- > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > ------- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
