----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ -----------------------------------------------------------
(Updated Март 16, 2017, 8:33 п.п.) Review request for KDE Frameworks and Anthony Fieroni. Changes ------- Added new test for ExtractorCollection. As for now, it simply checks if collection finds an extractor for known (text/plain) mimetype, and doesn't find anything for a-priory incorrect mimetype. Also removed unused include (otherwise test should have been linked with KI18N, which is actually not needed). Repository: kfilemetadata Description ------- After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer matches ANY of the text/ mimetypes. This broke completely Baloo indexing e.g. simple plain text files. Introduced check however allows to provide "text/plain" as supported mimetype for the extractor and hope that everything containing plain text will be inherited from it. Diffs (updated) ----- autotests/CMakeLists.txt 5ab742b autotests/extractorcollectiontest.cpp PRE-CREATION src/externalextractor.cpp 05f0645 src/extractors/plaintextextractor.cpp 26e1247 Diff: https://git.reviewboard.kde.org/r/130013/diff/ Testing ------- KFileMetaData compiles. Baloo indexes plain text files. Everybody is happy. Thanks, Igor Poboiko
