aacid added inline comments.

INLINE COMMENTS

> kfileplacesmodel.h:67
>  
> -    KFilePlacesModel(QObject *parent = nullptr);
> +    KFilePlacesModel(QObject *parent = nullptr, const QString 
> &alternativeApplicationName = {});
>      ~KFilePlacesModel();

This breaks ABI so it's not acceptable.

Also how does this fix anything if the new alternativeApplicationName parameter 
is never passed in any of the existing constructors?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9332

To: renatoo, mwolff
Cc: aacid, ngraham, #frameworks

Reply via email to