mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesmodeltest.cpp:1276
> +    // create a new entry with alternative application name
> +    KBookmark bookmark = root.addBookmark(QStringLiteral("Extra entry"), 
> QUrl("search:/videos-alternative"), {});
> +    const QString id = QUuid::createUuid().toString();

QUrl(QStringLiteral("search:/videos-alternative"))

> kfileplacesmodel.h:67
>  
>      KFilePlacesModel(QObject *parent = nullptr);
> +    KFilePlacesModel(const QString &alternativeApplicationName, QObject 
> *parent = nullptr);

Add a comment for kf6 //kf6 merge with above method

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9332

To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks

Reply via email to