renatoo marked an inline comment as done.
renatoo added inline comments.

INLINE COMMENTS

> aacid wrote in kfileplacesmodel.h:67
> This breaks ABI so it's not acceptable.
> 
> Also how does this fix anything if the new alternativeApplicationName 
> parameter is never passed in any of the existing constructors?

Ok I created a new constructor to avoid ABI break;

In fact this does not fix anything this only create a functionally that will be 
used by #D9332 (dolphin) to load contents exclusive for contents panel, since 
it uses a different appName to store it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9332

To: renatoo, mwolff
Cc: aacid, ngraham, #frameworks

Reply via email to