simgunz updated this revision to Diff 24488. simgunz marked 8 inline comments as done. simgunz added a comment.
- Avoid cast by using member var to proxyModel - Initialize m_proxyModel to null pointer - Add access method to m_proxyModel, use it to avoid cast - Remove unuseful returns, call parent eventFilter if conditions unmatched REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=21990&id=24488 BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 AFFECTED FILES src/widgets/kopenwithdialog.cpp src/widgets/kopenwithdialog.h src/widgets/kopenwithdialog_p.h To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks
