dfaure added a comment.
The rest looks good.
INLINE COMMENTS
> kshelltest.cpp:139
> #else
> - QCOMPARE(sj("\"~qU4rK\" 'text' 'jo'\"jo\" $'crap' $'\\\\\\'\\e\\x21'
> ha\\ lo \\a", KShell::NoOptions, &err),
> - QString("'~qU4rK' text jojo crap '\\'\\''\x1b!' 'ha lo' a"));
> + QCOMPARE(sj(QStringLiteral("\"~qU4rK\" 'text' 'jo'\"jo\" $'crap'
> $'\\\\\\'\\e\\x21' ha\\ lo \\a"), KShell::NoOptions, &err),
> + QStringLiteral("'~qU4rK' text jojo crap '\\'\\''\x1b!' 'ha lo'
> a"));
Does this test still pass?
You can't use QStringLiteral when there are escape characters like \x21 in the
literal.
See https://commits.kde.org/clazy/49825f06fda23989961cfa41cd1576b58e2bcc5d for
details.
Please make sure to run `ctest` before and after.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
