poboiko added inline comments.
INLINE COMMENTS
> filecontentindexer.cpp:75
> + bool hadErrors = false;
> + connect(&process, &ExtractorProcess::failed, &loop, [&hadErrors,
> &loop]() { hadErrors = true; loop.quit(); });
> +
Is it OK to use `QObject::connect` inside a `while` loop? Those are not
`Qt::UniqueConnection`, won't they fire multiple times (more and more,
actually)?
> filecontentindexer.cpp:91
> + batchSize = idList.size() / 2;
> + }
> + process.start();
Do I understand correctly, that's a binary-search-like way to find the file
actually causing `extractor` to crash, and it will reindex some of the files in
a batch ~log2(batchsize) times?
Why don't we rely instead on its progress reporting, via `startedIndexingFile`
/ `finishedIndexingFile`?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D16266
To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
