poboiko added inline comments. INLINE COMMENTS
> bruns wrote in filecontentindexer.cpp:91 > But it is racy - if the file is replaced in the meantime, inode and filename > no longer match. This is not completely unlikely when dealing with temporary > files. > > It would make the code also significantly more complex, and I want it simple > here. It should only be hit in exceptional cases. > > Also, it is not to uncommon to have a batch of size one from the start, i.e. > when adding/modifying files. OK, we can simply count how many times we got `finishedIndexingFile`, and just go to the corresponding position in the batch. It's just the binary search here does look a bit unnecessary to me... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16266 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
