broulik added inline comments.

INLINE COMMENTS

> poboiko wrote in filecontentindexer.cpp:75
> Is it OK to use `QObject::connect` inside a `while` loop? Those are not 
> `Qt::UniqueConnection`, won't they fire multiple times (more and more, 
> actually)?

given `loop` lives on the stack it is destroyed when the scope is left and the 
connection severed

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

Reply via email to