bruns added inline comments. INLINE COMMENTS
> cfoster wrote in batchrenamejob.cpp:165 > Just making sure I understand you correctly. > Are you saying I should change the function to take the filename as a QString > and extract the filename from the QUrl outside of the function or change > url.toDisplayString() to url.fileName() within the function? `QString extension = GetFileExtension(url.fileName());` ... `static QString BatchRenameJobPrivate::GetFileExtension(QString filename)` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh
