bruns added inline comments. INLINE COMMENTS
> batchrenamejob.cpp:160 > > +//The function QMimeDatabase.suffixForFileName always converts the extension > to lower case > +//This function is a wrapper which avoids the coversion to lower case Space after `//` > batchrenamejob.cpp:161 > +//The function QMimeDatabase.suffixForFileName always converts the extension > to lower case > +//This function is a wrapper which avoids the coversion to lower case > +QString BatchRenameJobPrivate::GetFileExtension(QUrl url) helper, not wrapper > batchrenamejob.cpp:161 > +//The function QMimeDatabase.suffixForFileName always converts the extension > to lower case > +//This function is a wrapper which avoids the coversion to lower case > +QString BatchRenameJobPrivate::GetFileExtension(QUrl url) `co_n_version` > batchrenamejob.cpp:165 > + QMimeDatabase db; > + const size_t extensionLen = > db.suffixForFileName(url.toDisplayString()).length(); > + I think you can use `QUrl::filename()`, and you should do it from the calling code. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh
