bruns added inline comments. INLINE COMMENTS
> batchrenamejob.cpp:170 > + if (extensionLen) { > + extension = filename.right(extensionLen); > + } else { You can just return here. > batchrenamejob.cpp:175 > + if (dotIndex != -1) { > + extension = filename.mid(dotIndex+1); > + } just return REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh