-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117366/#review65183
-----------------------------------------------------------
This patch actually broke the contact list presence display --
$ mc-tool dump
Presences:
Automatic: available (2) ""
Current: offline (1) ""
Requested: available (2) ""
Changing: yes
...but contact list now shows me as online (have just one account), even the
account tooltip, which is clearly wrong.
As #116940, which was claimed as the patch needing this, is still uncommitted
(or yet properly understood), I'm leaning towards reverting this. At least
partially.
- Martin Klapetek
On May 7, 2014, 11:32 p.m., James Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117366/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 11:32 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-contact-list
>
>
> Description
> -------
>
> Use requestedPresenceChanged in the presence chooser, as well as calling
> onPresenceChanged after every selectable option that can trigger config
> changes or presence changes in onUserActivatedComboChange. This improves the
> contact list interaction with #116940. The selected presence is instantly
> activated instead of the last selected user presence when deactivating the
> nowPlaying status message plugin.
>
>
> Diffs
> -----
>
> global-presence-chooser.cpp 2047473
>
> Diff: https://git.reviewboard.kde.org/r/117366/diff/
>
>
> Testing
> -------
>
> Compile, runtime
>
>
> Thanks,
>
> James Smith
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
