-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117366/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 2:12 p.m.)


Review request for Telepathy.


Changes
-------

Attach the (small) patch to use currentPresence() in the tooltip. Partial 
revert.


Repository: ktp-contact-list


Description
-------

Use requestedPresenceChanged in the presence chooser, as well as calling 
onPresenceChanged after every selectable option that can trigger config changes 
or presence changes in onUserActivatedComboChange. This improves the contact 
list interaction with #116940. The selected presence is instantly activated 
instead of the last selected user presence when deactivating the nowPlaying 
status message plugin.


Diffs
-----

  global-presence-chooser.cpp 2047473 

Diff: https://git.reviewboard.kde.org/r/117366/diff/


Testing
-------

Compile, runtime


File Attachments (updated)
----------------

currentPresence in tooltip revert
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/25/b360f0b6-d077-4a1e-8700-815b384cc01c__ktp-contact-list-use-current-presence-for-tooltip.patch


Thanks,

James Smith

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to