> On Aug. 25, 2014, 11:14 a.m., Martin Klapetek wrote: > > This patch actually broke the contact list presence display -- > > > > $ mc-tool dump > > > > Presences: > > Automatic: available (2) "" > > Current: offline (1) "" > > Requested: available (2) "" > > Changing: yes > > > > > > ...but contact list now shows me as online (have just one account), even > > the account tooltip, which is clearly wrong. > > > > As #116940, which was claimed as the patch needing this, is still > > uncommitted (or yet properly understood), I'm leaning towards reverting > > this. At least partially. > > David Edmundson wrote: > but it should show it as spinning next to that..no? > > Martin Klapetek wrote: > No, the spinner is shown only when "connectionStatus == > Tp::ConnectionStatusConnecting"; so when the connectionStatus changes to > disconnected, the spinner stops. If anything, at least the combo tooltip must > show current presence, otherwise it's simply lying. > > David Edmundson wrote: > the connectionStatus in what you've described above would be connecting. > > It's a combo box, so it has to show what the user selected otherwise it > looks super broken. We've been through this before in the presence applet. > > James Smith wrote: > Attached is a patch for the tooltip to use currentPresence. This is a > partial revert. I didn't realize that the tooltip displayed all the connected > accounts. :) > > Martin Klapetek wrote: > The attached patch is missing, but I actually already have that patch and > working on a bit extended version, don't worry.
Can I reclose this? 6c44bd75b7748b423495295cb7c5fe3e6a6d0684 is now in Git with the attached patch. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117366/#review65183 ----------------------------------------------------------- On Aug. 25, 2014, 2:12 p.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117366/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 2:12 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-contact-list > > > Description > ------- > > Use requestedPresenceChanged in the presence chooser, as well as calling > onPresenceChanged after every selectable option that can trigger config > changes or presence changes in onUserActivatedComboChange. This improves the > contact list interaction with #116940. The selected presence is instantly > activated instead of the last selected user presence when deactivating the > nowPlaying status message plugin. > > > Diffs > ----- > > global-presence-chooser.cpp 2047473 > > Diff: https://git.reviewboard.kde.org/r/117366/diff/ > > > Testing > ------- > > Compile, runtime > > > File Attachments > ---------------- > > currentPresence in tooltip revert > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/25/b360f0b6-d077-4a1e-8700-815b384cc01c__ktp-contact-list-use-current-presence-for-tooltip.patch > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
