I really don't care. The original motivation was simply being able to cleanly put it as a tab inside the preferences dialog without nesting, I really didn't think putting them in a single list would make them undiscoverable (and this is the first I've heard that comment, to be honest). But I have no real attachment to it. I just hope we don't end up with nested tabs.
On Fri, Jan 12, 2018 at 03:42:12AM +0000, Seth Hillbrand wrote: > Hi All- > > Sorry, this seems to have gotten off-track. Let's pause the button > discussion for a moment. I'm really more concerned about the tree-list > layout hiding hotkeys from users. Does anyone feel like we need the > treelist here? > > Chris, I know this was originally your commit and I don't mean to be overly > negative about it. What was the original motivation for it? Would you be > open to my modifying it to improve the accessibility? > > Thanks- > Seth > > On 11. Januar 2018 um 19:24, Andrey Kuznetsov <kandre...@gmail.com> wrote: > > > If that would be the intended functionality, then I'd suggest "Reset > > Selected" instead of "Reset". > > > > On Thu, Jan 11, 2018 at 5:01 AM, yann jautard <brico...@free.fr> wrote: > > > >> what about keeping four buttons : > >> > >> *Defaults* that reset all hotkeys *of the current tab* to default > >> > >> *Reset* that reset *the selected* hotkey only to default > >> > >> *Cancel* that close the window and undo the current changes > >> > >> *Save* that close the window and save the current changes > >> > >> > >> With a tooltip when getting the mouse over each button that clearly says > >> this. > >> > >> > >> > >> On 11/01/2018 13:16, Clemens Koller wrote: > >> > >>> Hi! > >>> > >>> On 2018-01-11 02:07, Seth Hillbrand wrote: > >>> > >>>> I don't recall when this change happened but I'd like any feedback on > >>>> whether folks are adverse > >>>> to reverting to the 4.0.7 tabbed layout while keeping the "Reset" and > >>>> "Defaults" buttons, > >>>> that I think are really good additions. > >>>> > >>> I agree, but I still don't understand why we don't use the huge screen > >>> real-estate we have nowadays on our desks and display all of them in one > >>> table with i.e. four columns. It would be easy then to check the hotkeys > >>> across all tools without changing tabs. > >>> The Buttons "Default" might become "Reset all Hotkeys to Kicad's > >>> defaults. Are you sure Y/N?" > >>> The Buttons "Reset" might become "Reset to previous settings" - but that > >>> might simply be the "Cancel" button. > >>> > >>> > >>> The menu entry Help -> List Hotkeys seems redundant to Preferences -> > >>> Hotkey Options -> Edit Hotkeys. > >>> One of the dialogs might be removed. > >>> In the latest-git, the Hotkey '?' doesn't work for me. I get a beep, > >>> when I am lucky... usually it is just ignored. > >>> > >>> In Eeschema, the Help -> List Hotkeys doesn't show the '?' > >>> There the Hotkey-Editor can be reached via Preferences -> General > >>> Options -> Controls Tab... > >>> > >>> GUI consistency would improve UX a lot. These are IMO the low-hanging > >>> fruits to attract users to use Kicad. > >>> > >>> Regards, > >>> > >>> Clemens > >>> > >>> On 2018-01-11 02:07, Seth Hillbrand wrote: > >>> > >>>> I feel that there is a usability issue with the current hotkeys editor > >>>> that is a regression from the 4.0.7 hotkeys editor. > >>>> > >>>> I've attached images for both to this message. The current editor > >>>> opens with a tree view that hides the hotkeys below "Common". Users > >>>> would > >>>> be forgiven for not realizing that there were additional hotkeys specific > >>>> to each application -- see current_hotkeys.png > >>>> > >>>> Previously, the hotkeys were displayed in tabs that were, I think, more > >>>> clear -- see prev_hotkeys.png. > >>>> > >>>> I don't recall when this change happened but I'd like any feedback on > >>>> whether folks are adverse to reverting to the 4.0.7 tabbed layout while > >>>> keeping the "Reset" and "Defaults" buttons, that I think are really good > >>>> additions. > >>>> > >>>> -S > >>>> > >>>> > >>>> _______________________________________________ > >>>> Mailing list: https://launchpad.net/~kicad-developers > >>>> Post to : kicad-developers@lists.launchpad.net > >>>> Unsubscribe : https://launchpad.net/~kicad-developers > >>>> More help : https://help.launchpad.net/ListHelp > >>>> > >>>> _______________________________________________ > >>> Mailing list: https://launchpad.net/~kicad-developers > >>> Post to : kicad-developers@lists.launchpad.net > >>> Unsubscribe : https://launchpad.net/~kicad-developers > >>> More help : https://help.launchpad.net/ListHelp > >>> > >> > >> > >> _______________________________________________ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > >> > > > > > > > > -- > > Remember The Past, Live The Present, Change The Future > > Those who look only to the past or the present are certain to miss the > > future [JFK] > > > > kandre...@gmail.com > > Live Long and Prosper, > > Andrey > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp