http://bugs.async.com.br/show_bug.cgi?id=4299
--- Comment #1 from Johan Dahlin (not reading bugmail) <[email protected]> 2011-02-15 12:37:03 BRT --- (From update of attachment 5510) >=== modified file 'kiwi/ui/entry.py' >- if HAVE_2_6: Can you kill the HAVE_2_6 define above as well? [and perhaps check if any imports can go] >+ def _update_position(self): >+ if self.get_property('xalign') > 0.5: >+ self._icon_pos = gtk.POS_LEFT >+ else: >+ self._icon_pos = gtk.POS_RIGHT Not that we currently care too much, but what about text right-to-left? >+ def _on_notify_xalign(self, entry, pspec): >+ self._update_position() > def set_tooltip(self, text): >- self._icon.set_tooltip(text) >+ icon = 'primary-icon-tooltip-text' >+ if self._icon_pos == gtk.POS_RIGHT: >+ icon = 'secondary-icon-tooltip-text' Guess an else is easier to follow here. > def set_pixbuf(self, pixbuf): >- self._icon.set_pixbuf(pixbuf) >+ icon = 'primary-icon-pixbuf' >+ if self._icon_pos == gtk.POS_RIGHT: >+ icon = 'secondary-icon-pixbuf' Ditto. > def update_background(self, color): >- self._icon.update_background(color) >+ self.modify_base(gtk.STATE_NORMAL, color) > > def get_background(self): >+ return self.style.base[gtk.STATE_NORMAL] I think you can just kill this of get_background() and do this at the get_background() callsite, which should only be one right? >=== modified file 'kiwi/ui/proxywidget.py' >+ # Tooltip must be set after the icon, to avoid errors What kind of "errors"? Be more specific. -- Configure bugmail: http://bugs.async.com.br/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Kiwi mailing list [email protected] http://www.async.com.br/mailman/listinfo/kiwi
