http://bugs.async.com.br/show_bug.cgi?id=4299
--- Comment #2 from Ronaldo Maia <[email protected]> 2011-02-15 13:24:06 BRT --- (In reply to comment #1) > Can you kill the HAVE_2_6 define above as well? > [and perhaps check if any imports can go] done > > >+ def _update_position(self): > >+ if self.get_property('xalign') > 0.5: > >+ self._icon_pos = gtk.POS_LEFT > >+ else: > >+ self._icon_pos = gtk.POS_RIGHT > > Not that we currently care too much, but what about text right-to-left? what about: if RTL: self._icon_pos = [gtk.POS_RIGHT, gtk.POS_LEFT][self._icon_pos] > Guess an else is easier to follow here. > Ditto. Fixed > I think you can just kill this of get_background() and do this at the > get_background() callsite, which should only be one right? There is only one call site indeed (ValidatableProxyWidgetMixin), but other classes overide this (like ComboBoxEntry, to return self._entry.get_background()) > What kind of "errors"? Be more specific. Changed to: # If you try to set the tooltip before the icon in gtk.Entry, a segfault happens -- Configure bugmail: http://bugs.async.com.br/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Kiwi mailing list [email protected] http://www.async.com.br/mailman/listinfo/kiwi
