http://bugs.async.com.br/show_bug.cgi?id=4299
--- Comment #3 from Johan Dahlin (not reading bugmail) <[email protected]> 2011-02-15 15:52:24 BRT --- (In reply to comment #2) > (In reply to comment #1) > > Can you kill the HAVE_2_6 define above as well? > > [and perhaps check if any imports can go] > > done > > > > > >+ def _update_position(self): > > >+ if self.get_property('xalign') > 0.5: > > >+ self._icon_pos = gtk.POS_LEFT > > >+ else: > > >+ self._icon_pos = gtk.POS_RIGHT > > > > Not that we currently care too much, but what about text right-to-left? > > what about: > > if RTL: > self._icon_pos = [gtk.POS_RIGHT, gtk.POS_LEFT][self._icon_pos] Yuk! That'd give you a price for great obfuscation skills. What's wrong with the dead simple: if RTL: if self._icon_pos == gtk.POS_LEFT: self._icon_pos = gtk.POS_RIGHT else if RTL: self._icon_pos = gtk.POS_LEFT > > I think you can just kill this of get_background() and do this at the > > get_background() callsite, which should only be one right? > > There is only one call site indeed (ValidatableProxyWidgetMixin), but other > classes overide this (like ComboBoxEntry, to return > self._entry.get_background()) Hmm, true. Leave it as it then I guess. > > > What kind of "errors"? Be more specific. > > Changed to: > # If you try to set the tooltip before the icon in gtk.Entry, a segfault > happens Much better, seems it was recently fixed (in 2.24.0): commit df0d61e Author: Tristan Van Berkom <[email protected]> Date: 2010-12-17 18:15:08 +0900 Fixed gtk_entry_set_icon_tooltip_text & markup to not crash Setting this property before the icon is actually set was resulting in a crash (found by way of Glade bug 606103). -- Configure bugmail: http://bugs.async.com.br/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Kiwi mailing list [email protected] http://www.async.com.br/mailman/listinfo/kiwi
