https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #44 from Pedro Amorim <[email protected]> --- Thank you Joubu for this very important work. My 2 cents: 1) QA script has several FAIL 2) t/db_dependent/TablesSettings.t syntax error -> is missing a comma on line 196. Tests fail after correcting that. 3) atomicupdate does not follow skeleton.pl Output 4) Testing suggestions table at /cgi-bin/koha/suggestion/suggestion.pl: - Created 2 suggestions with random title each - Did a search keyword for 'staff' - Clicked 'Copy conditions' - Opened new tab, pasted -> BOOM Error 500 with the following error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'DataTables_acqui_suggestions_suggestions_state' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 403 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Non-blockers / too hard for now: 1) "Copy conditions" button does not consider left-side filters on the patron search (and I suspect the same for ILL requests even though I have not tested, it works pretty much the same way i.e. left-side filters live outside of the datatable). 2) "Copy conditions" button does not exist on the items search table but that's expected as that table is very specific, and has this functionality specifically built for it. Obs: - Visiting a different page and returning to the suggestions table has kept the 'staff' keyword state, respecting the default_save_state_search, I'm assuming. - Visiting a different page and returning to the cities table has not kept the keyword state, respecting the default_save_state_search of false. Changing this value and testing again works as expected, i.e. it keeps the keyword state. - ERM Agreements table seems to be working as intended. - I suggest a new label for "Copy conditions". The item search button that does the same thing has "Copy shareable link" which I think it's much better/obvious to what it does. - "Save configuration state on page change" is this about columns configuration display only? If so, I suggest renaming this label to "Keep columns visibility state on page change". - Likewise "Save search state on page change:" I would suggest "Keep search state on page change" instead. We're "keeping" the state between page hops, no actual "saving" is happening. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
