https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484
--- Comment #45 from Jonathan Druart <[email protected]> --- (In reply to Pedro Amorim from comment #44) > Thank you Joubu for this very important work. My 2 cents: > > 1) QA script has several FAIL Fixed. > 2) t/db_dependent/TablesSettings.t syntax error -> is missing a comma on > line 196. Tests fail after correcting that. Fixed. > 3) atomicupdate does not follow skeleton.pl Output Please clarify, I am using the usual `say $out`, what is in skeleton. There is no clear definition for the uses of the other success/failure. The output for 24.11 is not consistent at all for the moment, that's a discussion for somewhere else. > 4) Testing suggestions table at /cgi-bin/koha/suggestion/suggestion.pl: > - Created 2 suggestions with random title each > - Did a search keyword for 'staff' > - Clicked 'Copy conditions' > - Opened new tab, pasted -> BOOM Error 500 with the following error: > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > execute failed: Unknown column > 'DataTables_acqui_suggestions_suggestions_state' in 'where clause' at > /kohadevbox/koha/Koha/Objects.pm line 403 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Those ugly scripts, erk. Fixed. ugly fix ofc... There is more to do to make it work on this table however. > Non-blockers / too hard for now: > 1) "Copy conditions" button does not consider left-side filters on the > patron search (and I suspect the same for ILL requests even though I have > not tested, it works pretty much the same way i.e. left-side filters live > outside of the datatable). I will write something to exclude some tables from the first iteration. Especially the ones with "additional filters" (ie. when some filters are outside of the table). > - I suggest a new label for "Copy conditions". The item search button that > does the same thing has "Copy shareable link" which I think it's much > better/obvious to what it does. Correct, done. I've also added a tooltip "Copied!" when the button is clicked (like on the item search). > - "Save configuration state on page change" is this about columns > configuration display only? If so, I suggest renaming this label to "Keep > columns visibility state on page change". There is a tooltip, it's the column visibility, number of results, sort order. > - Likewise "Save search state on page change:" I would suggest "Keep search > state on page change" instead. We're "keeping" the state between page hops, > no actual "saving" is happening. It's actually saving in the localStorage. But you are correct, for the end user it's more about keeping/restoring. I will adjust when we agree on a wording for the 2 entries. Changes from today: git range-diff joubu/old/20241017-bug_33484~27..joubu/old/20241017-bug_33484 joubu/bug_33484~32..joubu/bug_33484 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
