https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #49 from Jonathan Druart <[email protected]> --- (In reply to Pedro Amorim from comment #48) > Obs (other bugs, not here, if you agree): > 1) Libraries search does not search on address1 (or address2/address3) > despite it being shown. Yes, it deserves its own bug. > 2) ILL requests table needs to adopt external_filter_nodes to have external > filters included in the "Copy shareable link". Should be done here. Almost done, there is only the value for "Backend" and "Status" dropdown lists that are not restored. It seems that both are fetched in AJAX and I guess there is a race between DT that is loading its state (and selecting the options) and those requests. I've tried to move the code (populateStatusFilter) before the kohaTable init but it still does not work. Could you have look maybe? See commits Bug 33484: External filter into state - support flatpickr Bug 33484: External filter into state - ill requests > 3) qa script complains about console.logs in datatables.js and > columns_settings.inc but I don't consider these blockers console.log("Tag '%s' not supported yet for DT state".format(tag_name)) They are there on purpose. False positives. > Blocker: > t/db_dependent/selenium/patrons_search.t .. > # Failed test 'Searching in standard brings back correct results' > # at t/db_dependent/selenium/patrons_search.t line 285. > # got: 'No entries to show (filtered from 80 total entries)' > # expected: 'Showing 1 to 15 of 26 entries (filtered from 80 total > entries)' > > # Failed test 'Filtering on library works in combination with main > search' > # at t/db_dependent/selenium/patrons_search.t line 289. > # got: 'No entries to show (filtered from 80 total entries)' > # expected: 'Showing 1 to 15 of 25 entries (filtered from 80 total > entries)' > # Looks like you planned 7 tests but ran 1. > > # Failed test 'remember_search' > # at t/db_dependent/selenium/patrons_search.t line 407. > # Looks like you planned 28 tests but ran 27. > # Looks like you failed 3 tests of 27 run. Fixed! Fixed! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
