https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489
Chloé Zermatten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Chloé Zermatten <[email protected]> --- (In reply to Jonathan Druart from comment #8) > Not my expertise area but IMO we should not see screen size in JS: > > + if (window.screen.width > 991) { > + $(".menu-collapse-toggle").removeAttr("aria-expanded"); > + } > > Cannot we avoid that? > > Do we want the attribute to be adjusted if the window is resized? > > Could we have aria-expanded adjusted depending on the arrow visibility? Thank you for the feedback! I had a go at implementing this, hopefully it addresses the points you raised -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
