https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489
Chloé Zermatten <chloe.zermat...@openfifth.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #14 from Chloé Zermatten <chloe.zermat...@openfifth.co.uk> ---
(In reply to Julian Maurice from comment #12)
> Comment on attachment 182565 [details] [review]
> Bug 39489: 'Refine your search' aria-expanded attribute
>
> Review of attachment 182565 [details] [review]:
> -----------------------------------------------------------------
>
> ::: koha-tmpl/opac-tmpl/bootstrap/js/results-list.js
> @@ +240,4 @@
> > KOHA.Tags.add_tag_button(thisid, tag);
> > return false;
> > });
> > + $(window).on("resize load", function () {
>
> This is not needed: there is already a function (facetMenu) called on load
> and whenever the screen width goes under or above the break point of 992px
> (and only in that case, not on every resize)
> You should put the aria-expanded logic in facetMenu
>
> @@ +244,5 @@
> > + $(".menu-collapse-toggle").each(function () {
> > + const beforeContent = window.getComputedStyle(
> > + this,
> > + "::before"
> > + ).content;
>
> You should avoid relying on style to define behavior, because whenever the
> style change it might break functionality.
Thank you for the pointers - patch amended accordingly!
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
