https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489
--- Comment #12 from Julian Maurice <julian.maur...@biblibre.com> --- Comment on attachment 182565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182565 Bug 39489: 'Refine your search' aria-expanded attribute Review of attachment 182565: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=39489&attachment=182565) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/js/results-list.js @@ +240,4 @@ > KOHA.Tags.add_tag_button(thisid, tag); > return false; > }); > + $(window).on("resize load", function () { This is not needed: there is already a function (facetMenu) called on load and whenever the screen width goes under or above the break point of 992px (and only in that case, not on every resize) You should put the aria-expanded logic in facetMenu @@ +244,5 @@ > + $(".menu-collapse-toggle").each(function () { > + const beforeContent = window.getComputedStyle( > + this, > + "::before" > + ).content; You should avoid relying on style to define behavior, because whenever the style change it might break functionality. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
