Josh Hurst writes: > > Or that code review comments must > > consist of diffs? > This may be nice > > > > > Or perhaps something else? What would be "fair?" > Fair may be to start submitting some patches. Just some. Just to avoid > the impression that this project was done using slave labor
Ah, I see. In that case, I think you may be mistaken about the role that a "reviewer" plays in the development process. Perhaps other open source projects insist that review comments must be accompanied by diffs. Or that there's some sort of reciprocity involved: "I'll consider your suggestions only if you'll shoulder some of the project burden." That has simply never been the case with Solaris development, as it places far too high a burden on reviewers. It's hard enough to get people to do decent reviews of the work of others, and placing additional commitments on those who volunteer to do that work means that reviews will be meager at best. If what you're suggesting is that I can't comment on the code that Roland and others are offering until I've invested yet more time into _fixing_ that code, then I'm afraid I just don't agree with you, and I think the discussion is off-topic for this mailing list. If you feel strongly that I'm abusing my ability to offer comments, then you should bring this issue up with the Open Solaris community at large or with the CAB. -- James Carlson, KISS Network <james.d.carlson at sun.com> Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
