On Mon, Dec 24, 2007 at 08:50:13AM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > >On Sun, Dec 23, 2007 at 10:41:07AM +0200, Avi Kivity wrote: > > > >>Avi Kivity wrote: > >> > >>>Exactly. But it is better to be explicit about it and pass the page > >>>directly like you did before. I hate to make you go back-and-fourth, > >>>but I did not understand the issue completely before. > >>> > >>> > >>btw, the call to gfn_to_page() can happen in page_fault() instead of > >>walk_addr(); that will reduce the amount of error handling, and will > >>simplify the callers to walk_addr() that don't need the page. > >> > > > >But the gfn in question is only known at walk_addr() time, so thats not > >possible. > > > > It's just walker->gfn; certainly it is known in page_fault().
Oh, you mean to grab walker->gfn before fetch() ? Yeah, that makes sense. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
