Hollis Blanchard wrote: >> It doesn't have to be a package; it can be as simple as a tarball that >> people have to make; && sudo make install before compiling kvm, the same >> as other prerequisite libraries. >> > > Sure. Let's put that tarball inside the qemu directory, and then have it > extracted and built automatically when the user types "make". > > I'm really not clear on what advantage you think will be gained here. > >
If the package never changes in kvm-specific ways, there is no point in including it in kvm. The user can install it once, just like they install the X devel packages (for example) which we don't carry in kvm either. Is it indeed the case that no modifications are needed for kvm? >> The barrier should be whether we need to carry local changes or not. If >> we can use upstream as is, then it should be installed independently. >> > > So let me get this straight... you think it's cool to awk kernel source, > Awking the kernel source is not done for the sheer pleasure of it. It is painful to maintain and I only do it out of necessity. > but not to copy library code that was designed to be copied in the first > place? Seriously? Would it be more palatable to you if I ran awk over > arch/powerpc/boot/libdft? > Including the source in kvm is of course preferable to awk, but less preferable to an external dependency. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel