On Fri, Dec 05, 2008 at 04:25:31PM +0100, Jiri Slaby wrote: > Mark McLoughlin wrote: > >> Fix the virtio bus instead. > > > > Yeah, the patch I posted wasn't meant as a fix for this traceback. > > So what's the module_get patch needed for? > > > Here's one that does fix it. > ... > > From: Mark McLoughlin <[EMAIL PROTECTED]> > > Subject: [PATCH] virtio: add device release() function > > > > Add a release() function for virtio_pci devices so as to avoid: > > > > Device 'virtio0' does not have a release() function, it is broken and > > must be fixed
Just providing an empty release function to the kernel is the complete wrong thing. Do you not think the kernel is actually trying to tell you something here? If it could test for an empty release function it would complain about that as well, providing one is no "fix" at all. You need to free your memory in the release function that is owned by the device/structure. Please read the file, Documentation/kobject.txt for details as to what you need to do. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
