Il 04/01/2014 18:47, Jan Kiszka ha scritto:
> +     u64 old_state = vcpu->arch.apic_base &
> +             (MSR_IA32_APICBASE_ENABLE | X2APIC_ENABLE);
> +     u64 new_state = msr_info->data &
> +             (MSR_IA32_APICBASE_ENABLE | X2APIC_ENABLE);
> +     u64 reserved_bits = ((~0ULL) << boot_cpu_data.x86_phys_bits) | 0x2ff |
> +             (guest_cpuid_has_x2apic(vcpu) ? 0 : X2APIC_ENABLE);
> +

Should this use the guest CPUID instead?

> +     if (!msr_info->host_initiated &&

Is this check on host_initiated just for backwards compatibility, or is
there another case that I am missing?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to