Review: Approve <rockstar> jcsackett|lunch, thanks for PEP8ing tales.py <rockstar> jcsackett|lunch, so configure_translations and configure_blueprints head to the same URL? That doesn't make much sense to me. <rockstar> jcsackett|lunch, why did you remove the Copyright header in lib/lp/translations/tests/test_hastranslationtemplates.py * jcsackett|lunch is now known as jsackett <jsackett> rockstar: copyright notice was a goof, corrected. <jsackett> configure_blueprints and configure_translations are both links to edit, which is the place to set up both of those fields. configure_blueprints was added in the unknown-blueprints branch so that the template could be relatively consistent; the same intent and method was borrowed for this branch with configure_translations. <jsackett> (this is for the distribution, on product they point to different spots). <jsackett> rockstar ^ <rockstar> jsackett, okay. <rockstar> jsackett, I think this looks good. Thanks for the patch. -- https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel.
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
