The proposal to merge lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel has been updated.
Description changed to: Summary ======= Begins the process of moving translations to use the translations_usage enum for enabling or disabling the app for a given entity. Proposed Fix ============ Update template displays to use translations_usage; add necessary messaging and configuration options. Pre-Implementation Call ======================= Discussion and documentation from Curtis Hovey (sinzui). Further discussion with Jeroen Vermeulen (jtv) clarified goals and led to filing of bug #646101, which will have to be addressed in another branch. Implementation details ====================== As in proposed fix. ProductSeries and DistributionSeries still need some addressing, as does the overall configuration of Translations for a given product/distribution/series, but the current branch is usable. The relevant bug for an additional branch is bug #646101, as outlined in Pre-Implementation Call. Tests ===== bin/test -m lp.translations Demo and Q/A ============ Setting Product or Distribution should change the displayed data (e.g. setting NOT APPLICABLE should provide a NOT APPLICABLE message). I'll update this branch with sample data illustrating this before requesting a UI review. Lint ==== Output: = Launchpad lint = Checking for conflicts and issues in changed files. Linting changed files: lib/canonical/launchpad/webapp/configure.zcml lib/canonical/launchpad/webapp/tales.py lib/lp/registry/browser/configure.zcml lib/lp/registry/browser/distribution.py lib/lp/registry/browser/sourcepackage.py lib/lp/translations/browser/configure.zcml lib/lp/translations/browser/distribution.py lib/lp/translations/browser/distroseries.py lib/lp/translations/browser/product.py lib/lp/translations/browser/productseries.py lib/lp/translations/interfaces/potemplate.py lib/lp/translations/model/potemplate.py lib/lp/translations/templates/distribution-translations.pt lib/lp/translations/templates/distroseries-translations.pt lib/lp/translations/templates/product-translations.pt lib/lp/translations/templates/productseries-translations.pt lib/lp/translations/templates/translations-portlet-configuration.pt lib/lp/translations/templates/translations-portlet-not-using-launchpad-extra.pt lib/lp/translations/templates/translations-portlet-not-using-launchpad.pt lib/lp/translations/tests/test_hastranslationtemplates.py ./lib/canonical/launchpad/webapp/configure.zcml 668: Line has trailing whitespace. ./lib/canonical/launchpad/webapp/tales.py 237: W602 deprecated form of raising exception 518: W602 deprecated form of raising exception 798: W602 deprecated form of raising exception 1984: E231 missing whitespace after ',' 2236: E302 expected 2 blank lines, found 1 ./lib/lp/translations/browser/configure.zcml 943: Line has trailing whitespace. ./lib/lp/translations/interfaces/potemplate.py 763: E301 expected 1 blank line, found 2 777: E301 expected 1 blank line, found 2 Whitespacing errors and blank lines are all okay (tuples of one, comments &c). -- https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
