Review: Approve ui*
This is probably unrelated to your changes, but I thought I'd mention anyway: 
when looking at https://translations.launchpad.dev/kubuntu anonymously I see 
only the one sentence stating LP doesn't know about translations for it, but 
when I'm logged in as an admin I see all the edit links (which is expected) and 
the list of translations for the krunchy distro series (which I wasn't 
expecting given that it's not shown for anonymous users). Maybe Jeroen knows 
why?

This is probably not related either, but on 
https://translations.launchpad.dev/kubuntu/krunch, why am I allowed to change 
translations' permissions/settings even though LP is not used to translate 
kubuntu? I'd expect to be directed to /kubuntu to configure translations 
instead.

And similar to my suggestion in that previous UI review, when the 
project/distro does not use LP for translations, you could change the text of 
the 'Configure translations' link to 'Use Launchpad to translate <name', but 
that's not something you've changed, so I wouldn't block the landing of this 
branch because of that.
-- 
https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464
Your team Launchpad code reviewers is requested to review the proposed merge of 
lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into 
lp:launchpad/devel.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to