>This will find the string even in strings and comments. Yes. This won't be useful in future when all widgetsets will be in one encoding AND/OR when there will be another mechanism to translate .lfm files (this hack is a bad idea, I agree, but it WORKS). May be LFM comments? Besides, placing {%encoding } strictly in front can result in troubles. For example, adding a LF to the front shouldn't break anything.
>You moved the test for {%encoding } in front of the test for BOM, Yes, it may be. But it works if anyone want quickly translate a file. For example, there is a wrongly BOMed cp1251 file. He adds {%encoding CP1251}, and all OK. Or to export file... While Lazarus doesn't place BOM in its file, such a test can be prior to %encoding. >I think the new feature should be enclosed in IFDEF EnableSrcEncoding >until it is well tested. It is reasonable. _________________________________________________________________ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives