no joy Terry. a) forgot to `import sys`, but after fixing that it b) breaks pip.
traceback in the bug report, https://github.com/leo-editor/leo-editor/issues/81 On Tue, Oct 28, 2014 at 8:40 AM, 'Terry Brown' via leo-editor < leo-editor@googlegroups.com> wrote: > On Mon, 27 Oct 2014 12:01:48 -0500 > "'Terry Brown' via leo-editor" <leo-editor@googlegroups.com> wrote: > > > On Mon, 27 Oct 2014 11:29:54 -0500 > > "Edward K. Ream" <edream...@gmail.com> wrote: > > > > > On Mon, Oct 27, 2014 at 11:22 AM, Kent Tenney <kten...@gmail.com> > > > wrote: > > > > My experience has been: pip is happy with setup.py, > > > > installs correctly. > > > > > > > > if 'install' in sys.argv: > > > > print "WARNING: 'setup.py install' is known to not work." > > > > print "Either use 'setup.py develop', or run launchLeo.py > > > > directly" print "or run 'pip install .'" > > > > sys.exit() > > > > > > I suppose the question is, does 'install' appear on the command line > > > when Ville uses setup.py? > > > > I think Ville can sort that out for himself if he every uses it again. > > Ok, I just pushed this fairly simplistic change: > > +if not os.environ.get('_', '').endswith('pip'): > + print( > + "setup.py is only used for `pip` installs, please see:\n" + > + "http://leoeditor.com/installing.html"; > + ) > + sys.exit() > > Could someone test on Windows please? > > So basically we're saying that `python setup.py install` is currently > broken (but at least we make that clear), and the file's there for > pip. If Ville builds more .deb or whatever they are he can fix it then. > > Cheers -Terry > > > Right now the question is does 'install' appear on the command line > > when `pip` uses setup.py. But more to the point, how to tell if `pip` > > us using setup.py. > > > > I think I have a solution, but I can't push it because the file has > > weird sentinel crap in it :-) "@file ../../setup.py" but I find no > > such reference in any .leo file. I think it should be vanilla python > > without sentinels, setup.py is a file where people often read the > > source, but more to the point I'm a Leo developer and can't work out > > how to modify it without potentially breaking something. > > > > Hmm, maybe it needs "@file ../../setup.py" added to LeoPy*Ref*.py, not > > LeoPy.py as I suspect happened at 0b203eee. > > > > Cheers -Terry > > > > -- > You received this message because you are subscribed to the Google Groups > "leo-editor" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to leo-editor+unsubscr...@googlegroups.com. > To post to this group, send email to leo-editor@googlegroups.com. > Visit this group at http://groups.google.com/group/leo-editor. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
