Few nits related to the shell. In the network script:
> # Process individual configuration files
> for file in `ls "${dir}"`; do
Ew. :-) How about:
for file in "${dir}"/* ; do
ONBOOT=`grep "ONBOOT" "${file}" | sed ...
...
(since it always does a ${dir}/${file} as written)
In the ifup/ifdown scripts:
> else
> grep "${INTERFACE}" /proc/net/dev 2>&1 > /dev/null
> if [ "${?}" != "0" ]; then
Why not a (simpler):
if grep "${INTERFACE}" /proc/net/dev 2>&1 > /dev/null ; then
instead? (This is done in several places: anywhere the script is
testing the value of "$?" can potentially be simplified.)
> echo "ERROR: ${INTERFACE} is not a valid network interface."
> echo ""
> exit2
That should be "exit 2", right? :-)
> fi
> fi
signature.asc
Description: OpenPGP digital signature
-- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
