On Mon, 2012-01-16 at 22:34 -0800, Bryan Kadzban wrote:
> Reading through the patch:
> 
> Matt Burgess wrote:
> > And here's the latest version that I've just kicked off a build for. 
> > This one even has the kmod.xml file in it that the last version
> > didn't. It applies on top of Bruce's fstab and bootscript changes in
> > r9710.
> 
> > +<screen><userinput 
> >   remap="configure">BLKID_CFLAGS="-I/usr/include/blkid" 
> >   BLKID_LIBS="-L/usr/lib -lblkid" \
> > +  KMOD_CFLAGS="-I/usr/include" KMOD_LIBS="-L/usr/lib -lkmod"
> >   ./configure \
> 
> Hmm.  Kmod was configured, below, with:
> 
> > +  --prefix=/usr --bindir=/bin --libdir=/lib --sysconfdir=/etc ...
> 
> which means it put its libraries in /lib, not /usr/lib.  Should
> KMOD_LIBS be changed to reflect that?

Yes, it should.

>   (Same with BLKID_LIBS, actually,
> though I haven't looked at where libblkid gets installed these days.

libblkid currently gets installed into /usr/lib, which is a shame
really, because that breaks separate /usr again.  I'll run another test
build passing --libdir=/lib to e2fsprogs and see what falls out.

> Same with liblzma_LIBS or whatever it is, and libz_LIBS, on the kmod
> installation; xz also gets --libdir=/lib, and zlib is handled manually.)

Yeah, both xz and zlib install their libraries to /lib, but oddly
enough, kmod still found them after telling it that they were
in /usr/lib.  I guess the linker's searching in /lib by default?
Anyway, I've updated the patch to fix things up.

Thanks for the review,

Matt.

-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to