On Sat, 23 Apr 2011, Ronald S. Bultje wrote:
> Hi,
>
> On Fri, Apr 22, 2011 at 5:39 PM, Martin Storsjö <mar...@martin.st> wrote:
> > On Wed, 20 Apr 2011, Martin Storsjö wrote:
> >
> >> From: Kirill Gavrilov <gavr.m...@gmail.com>
> >>
> >> All file names should be in UTF-8 within libavformat.
> >>
> >> This is handled by mapping the open() function to an internal one
> >> in os_support.h for windows.
> >>
> >> fopen() could be overridden in the same way, but if that would be
> >> used from ffmpeg.c, it would add a dependency on an ff prefixed
> >> internal lavf function.
> >
> > Any comments on this cleaned up version of the hacks (except for the minor
> > issues Diego pointed out, that I fixed locally)?
>
> Personal opinion: for non-win32, please implement it as static inline
> void in the header, so that it becomes a nop.
As discussed on irc, this was a misconception, the thing discussed wasn't
a function in a header, it was a function in cmdutils.c called only from
there. Added an inline declaration on the empty function though, and
pushed.
// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
