On Wed, Oct 12, 2011 at 04:23:42PM +0200, Diego Biurrun wrote:
> On Wed, Oct 12, 2011 at 01:35:19PM +0100, [email protected] wrote:
> >
> > --- a/avconv.c
> > +++ b/avconv.c
> > + for (i = 0; i < FF_ARRAY_ELEMS(base) && ret; i++) {
> > + if (!base[i])
> > + continue;
> > + if (codec_name) {
> > + snprintf(filename, sizeof(filename), "%s%s/%s-%s.ffpreset",
> > base[i],
> > + i != 1 ? "" : "/.avconv", codec_name, preset_name);
> > + ret = avio_open(s, filename, AVIO_FLAG_READ);
> > + }
> > + if (ret) {
> > + snprintf(filename, sizeof(filename), "%s%s/%s.ffpreset",
> > base[i],
> > + i != 1 ? "" : "/.avconv", preset_name);
> > + ret = avio_open(s, filename, AVIO_FLAG_READ);
> > + }
> > + }
>
> I think this is not quite what we want. The directory name we search
> should only be a hidden directory with a leading period in the home
> directory. For the system directories it is customary to use normal
> directory names, i.e.
>
> /home/foo/.avconv/
> /usr/share/avconv/
it does that, the /.avconv is only added for getenv("HOME"),
in the other cases the final '/avconv' is expected to be in base[]
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
