On 10/12/11 10:47 PM, Anton Khirnov wrote:
On Wed, 12 Oct 2011 16:23:42 +0200, Diego Biurrun<[email protected]> wrote:
On Wed, Oct 12, 2011 at 01:35:19PM +0100, [email protected] wrote:
--- a/avconv.c
+++ b/avconv.c
@@ -2966,15 +2968,62 @@ static void parse_forced_key_frames(char *kf,
OutputStream *ost,
+ while ((c = avio_r8(s))&& (c != '\n'))
The second set of parentheses is unnecessary.
+static int get_preset_file_2(const char *preset_name, const char *codec_name,
AVIOContext **s)
nit: This long line can easily be shortened.
Why the _2 suffix in the function name?
Because there's already a get_preset_file() in cmdutils, used by ffmpeg
and avserver.
I guess we could keep as you have in the patch and later move it to avutils.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
