On Wed, 12 Oct 2011 16:23:42 +0200, Diego Biurrun <[email protected]> wrote:
> On Wed, Oct 12, 2011 at 01:35:19PM +0100, [email protected] wrote:
> >
> > --- a/avconv.c
> > +++ b/avconv.c
> > @@ -2966,15 +2968,62 @@ static void parse_forced_key_frames(char *kf,
> > OutputStream *ost,
> >
> > + while ((c = avio_r8(s)) && (c != '\n'))
>
> The second set of parentheses is unnecessary.
>
> > +static int get_preset_file_2(const char *preset_name, const char
> > *codec_name, AVIOContext **s)
>
> nit: This long line can easily be shortened.
>
> Why the _2 suffix in the function name?
Because there's already a get_preset_file() in cmdutils, used by ffmpeg
and avserver.
This one is based on it, except that it uses avio.
> > @@ -3942,6 +4015,7 @@ static const OptionDef options[] = {
> > { "codec", HAS_ARG | OPT_STRING | OPT_SPEC, {.off =
> > OFFSET(codec_names)}, "codec name", "codec" },
> > + { "pre", HAS_ARG | OPT_STRING | OPT_SPEC, {.off = OFFSET(presets)},
> > "preset name", "preset" },
> > { "map", HAS_ARG | OPT_EXPERT | OPT_FUNC2, {(void*)opt_map}, "set
> > input stream mapping", "file.stream[:syncfile.syncstream]" },
>
> I suggest "preset" instead, which is much more intuitive.
Conflicts with existing AVOptions.
--
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
