On 11/24/2012 09:58 AM, Christophe Gisquet wrote:
> Hi,
>
> 2012/3/4 Ronald S. Bultje <rsbul...@gmail.com>:
>> > Since you're working on this, would you mind adding one (or a few)
>> > fate tests so we can ensure that we don't break this while we're
>> > optimizing it?
> I have no idea how to do that, and I would probably need several times
> the time it takes for anyone used to it, but why not.
>
> Anyway, here are updated patches.
>
> Note that the neon code in libavcodec/arm/int_neon.S needs to be modified.
>
[...]
> +/** Get sign of integer (1 for positive, -1 for negative and 0 for zero) */
> +static inline int WMASIGN(int32_t x) {
> + return (x > 0) - (x < 0);
> +}
> +
Either make the function name lowercase or make it a macro. Also, if you
leave it as an inline function, put the opening brace on a separate line.
Besides that, both patches look ok.
-Justin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
