Hello,

In svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx, I noticed the use of va_start without va_end.
I read it could create undefined behaviour, so I propose this simple patch.

I propose this patch :
diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx
index 3be762d..0ca7223 100644
--- a/svl/source/items/itemset.cxx
+++ b/svl/source/items/itemset.cxx
@@ -225,6 +225,7 @@ SfxItemSet::SfxItemSet( SfxItemPool& rPool,
             pArgs, sal::static_int_cast< sal_uInt16 >(nWh1),
             sal::static_int_cast< sal_uInt16 >(nWh2),
             sal::static_int_cast< sal_uInt16 >(nNull));
+        va_end(pArgs);
     }
 }

If it's ok, i can commit and push it on master.

Julien.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to